Comment PR #502
Draft
Comment PR #502
+19,427
−1,901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
Co-authored-by: William Richter <[email protected]> Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
Co-authored-by: William Richter <[email protected]> Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
Co-authored-by: Aleksandr Petrosyan <[email protected]> Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
Co-authored-by: William Richter <[email protected]> Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
Co-authored-by: Aleksandr Petrosyan <[email protected]> Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: 0x009922 <[email protected]>
[CI]: target `main` branch in GitHub workflows
) * #73, #60: Update info about roles, mark statements about the future Signed-off-by: Ekaterina Mekhnetsova <[email protected]> * Fix formatting Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: 6r1d <[email protected]>
* [docs]: update version note in js guide Signed-off-by: 0x009922 <[email protected]> * [chore]: fix formatting Signed-off-by: 0x009922 <[email protected]>
Fix docker-compose command
Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: 6r1d <[email protected]> Co-authored-by: 0x009922 <[email protected]> Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
nxsaken
commented
Jul 8, 2024
There was a problem hiding this comment.
Should be renamed according to hyperledger-iroha/iroha#4810, see the change in the README for smart contracts
* Getting started update and overhaul Signed-off-by: a_zorina <[email protected]> Signed-off-by: a-zorina <[email protected]> * fix broken links Signed-off-by: a_zorina <[email protected]> Signed-off-by: a-zorina <[email protected]> * fix section links Signed-off-by: a_zorina <[email protected]> Signed-off-by: a-zorina <[email protected]> * Language and structure improvements Signed-off-by: a-zorina <[email protected]> * External links and crate names fixes Signed-off-by: a-zorina <[email protected]> * Switch to using cargo install for iroha binaries in getting started Signed-off-by: a-zorina <[email protected]> * Minor post-review fixes Signed-off-by: a-zorina <[email protected]> * Fixes and suggestions after review Signed-off-by: yamkovoy <[email protected]> * Changes after discussion Signed-off-by: yamkovoy <[email protected]> * Minor tweaks in instructions Signed-off-by: yamkovoy <[email protected]> * Additional post-review updates Signed-off-by: a-zorina <[email protected]> * link fixes Signed-off-by: a-zorina <[email protected]> * final post-review changes Signed-off-by: a-zorina <[email protected]> --------- Signed-off-by: a_zorina <[email protected]> Signed-off-by: a-zorina <[email protected]> Signed-off-by: yamkovoy <[email protected]> Co-authored-by: yamkovoy <[email protected]>
Closed
* Update new structure with recent changes Signed-off-by: a-zorina <[email protected]> * tweaks to structure after discussions Signed-off-by: a-zorina <[email protected]> * tweaks to Iroha Explained section Signed-off-by: a-zorina <[email protected]> * format fix Signed-off-by: a-zorina <[email protected]> --------- Signed-off-by: a-zorina <[email protected]>
* link fixes due to migration Signed-off-by: a-zorina <[email protected]> * Update src/guide/tutorials/rust.md Signed-off-by: Ekaterina Mekhnetsova <[email protected]> --------- Signed-off-by: a-zorina <[email protected]> Signed-off-by: Ekaterina Mekhnetsova <[email protected]> Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
misc: update dependencies Signed-off-by: qua <[email protected]>
Signed-off-by: tarmovannas <[email protected]>
* link fixes due to migration Signed-off-by: a-zorina <[email protected]> * Update src/guide/tutorials/rust.md Signed-off-by: Ekaterina Mekhnetsova <[email protected]> * Miscellaneous docs updates + testnet links + binaries reference Signed-off-by: a-zorina <[email protected]> * Updates after review Signed-off-by: a-zorina <[email protected]> * Fix for broken link Signed-off-by: a-zorina <[email protected]> --------- Signed-off-by: a-zorina <[email protected]> Signed-off-by: Ekaterina Mekhnetsova <[email protected]> Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
* fix: extend default theme correctly Signed-off-by: quacumque <[email protected]> * docs: update torii reference according to `rc.1.0` Signed-off-by: quacumque <[email protected]> * ci: bump node version Signed-off-by: quacumque <[email protected]> * ci: update corepack to latest Signed-off-by: quacumque <[email protected]> * docs: fix broken anchor Signed-off-by: quacumque <[email protected]> * Apply suggestions from code review Co-authored-by: Alexandra Zorina <[email protected]> Signed-off-by: 0x009922 <[email protected]> * docs: update iroha rev, revise query section Signed-off-by: qua <[email protected]> * docs: refine queries table Signed-off-by: qua <[email protected]> --------- Signed-off-by: quacumque <[email protected]> Signed-off-by: 0x009922 <[email protected]> Signed-off-by: qua <[email protected]> Co-authored-by: quacumque <[email protected]> Co-authored-by: Alexandra Zorina <[email protected]>
docs: update config endpoints Signed-off-by: quacumque <[email protected]> Co-authored-by: quacumque <[email protected]>
Co-authored-by: William Richter <[email protected]> Co-authored-by: Ekaterina Mekhnetsova <[email protected]> Co-authored-by: yamkovoy <[email protected]> Co-authored-by: qua <[email protected]>
Co-authored-by: William Richter <[email protected]> Co-authored-by: quacumque <[email protected]> Co-authored-by: Alexandra Zorina <[email protected]>
Typo "mind assets" -> "mint assets" Signed-off-by: Mathieu Legrand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to hopefully use for comments. Do not merge this.